Detect operating environment and adjust certain behaviors.#83
Merged
Conversation
xenoscopic
force-pushed
the
model-runner-environment
branch
from
2220cdf to
ce019fb
Compare
p1-0tr
approved these changes
Jun 16, 2025
doringeman
approved these changes
Jun 16, 2025
doringeman
left a comment
doringeman
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a tiny nit.
(FWIW for further reference, linked to docker/model-cli#91)
This commit introduces a new environment detection mechanism based on process name and environment variables. It uses this information (initially) for the purposes of tuning concurrent model behaviors on cloud. Signed-off-by: Jacob Howard <jacob.howard@docker.com>
xenoscopic
force-pushed
the
model-runner-environment
branch
from
ce019fb to
0cd306e
Compare
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 23, 2025
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 24, 2025
doringeman
added a commit
to doringeman/model-runner
that referenced
this pull request
Oct 2, 2025
Don't bind the bridge gateway IP if we're treating Docker Desktop as Moby
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new environment detection mechanism based on process name and environment variables.
It uses this information (initially) for the purposes of tuning concurrent model behaviors on cloud.